helm: configurable Service annotations #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
arikalon1
reviewed
Dec 1, 2024
There was a problem hiding this comment.
Thanks for the PR @pznamensky
Nice work
Left a small comment in the review
helm/robusta/values.yaml
Outdated
| @@ -35,6 +35,11 @@ globalConfig: | |||
| custom_annotations: [] | |||
| custom_severity_map: {} | |||
|
|
|||
| # k8s service config | |||
| service: | |||
There was a problem hiding this comment.
Do you think we can move this into the runner section?
Since these annotations are for the runner service, I think it might belong there
There was a problem hiding this comment.
runner section indeed seems to be a better place for that.
Thanks for taking a look!
arikalon1
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
In our infrastructure, we need to add custom annotations to k8s services in order to configure load balancers. Currently we have to patch Service resource after installing Robusta which is not very convenient.
As it seems to be a common case, I think it would be worthwhile to add the corresponding helm values into the chart.